Make heart icon consistent across screens

ULJgN · March 27, 2025, 11:36pm

Feature description:

There are multiple places where a songs “favorite” status is indicated, and where it can be toggled. The icons for it are not consistent in all spots, in some places a solid/filled in heart indicates that the song is a favorite while an outline of a heart indicates it is not a favorite, and in other places it’s the opposite, a solid heart is not a favorite but an outline is.

Problem solved:

Consistent ui elements reduce confusion as to whether a song is a favorite or not

Brought benefits:

consistency

Additional description and context:

The more details the better to understand the need and figure out the best solution.

Screenshots / Mockup:

If possible please provide screenshots of your idea of the implementation or how other application do this.

In these examples, the only favorite is the single version of “time in a tree”, with the blue album art. The other songs, including the album version of “time in a tree” are not favorites. But, they all have spots where the favorite icon is filled in and other spots where it’s an outline

Tolriq · March 28, 2025, 6:15am

It is consistent;)

One show the current state, the other show the state that you will give.

ULJgN · March 28, 2025, 1:09pm

Not on the now playing screen. On the now playing screen, it’s filled in if it’s a favorite, but tapping it would remove it from favorites. So if the logic is “filled in = favorite” and “tappable elements show what the state would be if you tap it”, it’s inconsistent there

but more generally, I think “tappable elements show what the state would be if you tap it” is a very confusing way to set up the ui, and not how the majority of uis are. For example, by that logic this switch should be off, because tapping it would disable dark theme

ULJgN · March 28, 2025, 1:17pm

Although a counterpoint to myself, that’s how signal handles the ui for pinning chats

I guess it does make sense when there’s the text describing what tapping would do, but in the multi-select I’m not so sure. In that case it doesn’t have the text and seems more like the one on the now playing screen. But either way, not a big deal