Changed .lrc content in lms is not updated in Symfonium

Support
1

Issue description:

After changing the content of an .lrc file, I expect this change to appear in Symfonium after a server rescan and a sync in Symfonium. However the old data is retained even tho the file is not offline-cached.

Logs:

Upload description: 655321 lms changed .lrc not updated

Additional information:

 
I changed the offset in the .lrc file to -1234 (was -4000 before which was also ignored by Symfonium).
Then let lms rescan and synced the provider in Symfonium.
At this point I started debug logging in Symfonium. I first searched for the song name in the offline cache (no results) with the rolling cache being empty and then played it.
According to the log, the -1234 offset was returned by lms ({"structuredLyrics":[{"lang":"xxx","offset":-1234,), but not used in Symfonium.

 

Reproduction steps:

 

  1. play a song with external .lrc file in Symfonium.
  2. change the content of the .lrc file
  3. let lms scan for changes
  4. sync the lms provider in Symfonium
  5. clear the rolling cache in Symfonium
  6. play the song again

 

Media provider:

Subsonic

Screenshots:

     

2

Your file have a SYLT tag it’s probably used if the server version does not have more lines.

3

It might have had one at one point, but according to my hex editor (ImHex), it does not.

grafik
grafik544×590 10.9 KB

4

Well then Symfonium invent data :slight_smile:

You probably have the media in the playback cache.

5

Sorry. It actually still did have a SYLT tag. The embedded image just threw me off since I usually don’t embed images.

I think it would be preferable if Symfonium used the OS response if present with embedded tags as a fallback (and there LYRICS > SYLT as SYLT is more limited). As my case proves, just deciding by which has the most lines is not always best. :wink:

6

And what when multiple tags and multiple server versions and and and.

There’s not a single always best source of truth for this case.

So until I eventually support multiple ones and selection this is the best that can be done.

7

Then perhaps add an option to display the lyrics source to avoid confusion? Something like (getLyrics/SYLT/LYRICS/.lrc) at the bottom of the lyrics if the option is on?
That would make troubleshooting why changed lyrics don’t make it into Symfonium a lot more straightforward.

8

One day if there’s support for multiple lyrics. For now the amount of rework just for you is not worth it.

9

I only encountered it during testing. There’s a reason why I chose to never embed lyrics (which I could easily do for all my files in a couple minutes with my script).
Multiple sources of truth are a major pain in the butt.
Let’s just hope future confused users find this thread. :slightly_smiling_face: