Incorrect UI when starring / unstarring a song fails

Support
1

Issue description:

When using the heart button to star / unstar a song in the “now playing” screen, the icon changes accordingly, even when the server returned an error.

For instance, if I click the empty heart icon to star a song, and the server returns an error, the song will remain unstarred on the server side but will be considered starred by Symfonium showing the full heart icon.

2

ThatSymfoniumUserThatDecidedToIgnoreTheWizardAndNotProvideTheMandatoryLogs

3

Indeed, because it doesn’t provide anything here. The problem appears if the server returns a 404, 500 etc. error, it isn’t dependent on anything related to the application itself.

4

I’m so tired of users who think rules don’t apply to them and that they know better and think it’s normal to make everyone loose time …

  1. Symfonium is offline first so can change rating even with server offline it will be tried again later.
  2. Symfonium will retry later to sync the rating to the server
  3. Unless the server is a Subsonic server and the server returns some kind of errors like 404 in that case Symfonium assume that the server does not implement the end point and will stop trying again.

So yes the fucking logs are necessary, and I’ve just lost 5 minutes of my life for absolutely no reason :slight_smile:

1 Like
5

Ok sorry, I’ll upload the logs later on.

Just for info the server is a Subsonic one and does return a 404, hence why I was curious. I’ll try to upload the logs later today.

6

There’s no need you just have given the answer yourself.

This is normal and by design due to how Subsonic API is implemented differently by many different servers and the reason I created OpenSubsonic.

7

Oh sorry I meant it’s an OpenSubsonic server, not Subsonic. I forgot the two didn’t have the same API.

For the whole context, I have my own OpenSubsonic server implementation, and I recently started using it as a backend for Symfonium. I’m implementing routes one by one, but I won’t support starring / unstarring songs as I prefer relying on explicit star-based rating which is more precise.

And that’s how I discovered the bug.

Didn’t know you were the creator of OpenSubsonic though, that’s quite an accomplishment :slight_smile:

8

There’s no extension in OS about ratings, so it’s still the normal behaviour 404 means the endpoint is not implemented so it’s skipped as expected.

9

So does that mean Symfonium tracks internally what song has been rated or not, independently of the server when that feature it not supported by it?

And also is there any way to disable support for the star / unstar system in Symfonium completely? Or is the only solution hiding these buttons?

10

Yes in most case it keeps it’s internal state and no you can remove the buttons everywhere.

1 Like
11

Well, too bad ^^

Thanks for clarifying though!